Add path parameter to load_kl1/kl11_camera #22
Conversation
Currently the methods "load_kl11_camera" and "load_kl1_camera" are hard-linked to a specific camera calibration file saved in Matthew Carr's home. Adding an optional parameter willallow creating camera with different calibrations.
|
This looks good to me. I wonder if we can go one step further and actually include the calibration files in this package, much like we already do with the KB5 geometry for example? Would probably need to check that it's OK to add the files to an EUPL project first. By the way, the default path doesn't work any more on Heimdall: that file does exist but its permissions are set so that only the |
|
I think that calibration files (if there are any available and authorised) should be stored somewhere at JET cluster, where they are accessible. I think this should be discused with the ROs where the files would be stored. This would be in general a much better solution. |
|
I agree: the most important thing is that this data should be easily accessible. Whether that's by being incorporated into this package or stored in a suitable central location doesn't really matter. But we do need to move away from critical data files being stored in users' home directories as we risk losing access when those users move on. This is not just a KL1/KL11 problem either. |
Currently the methods "load_kl11_camera" and "load_kl1_camera" are hard-linked
to a specific camera calibration file saved in Matthew Carr's home.
Adding an optional parameter willallow creating camera with different calibrations.